New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced the number of ClusterStateUpdateTask variants #13735

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@bleskes
Member

bleskes commented Sep 23, 2015

In the past ClusterStateUpdateTask was an interface and we had various derived marker interfaces to control behavior. Since then we moved ClusterStateUpdateTask to be an abstract class but we kept the old hierarchy of implementations. All of those (but the AckedClusterStateUpdateTask) can be folded into ClusterStateUpdateTask, adding correct default behavior.

Reduced the number of ClusterStateUpdateTask variants
In the past ClusterStateUpdateTask was an interface and we had various derived marker interfaces to control behavior. Since then we moved ClusterStateUpdateTask to be an abstract class but we kept the old hierarchy of implementations. All of those (but the AckedClusterStateUpdateTask) can be folded into ClusterStateUpdateTask, adding correct default behavior.
@bleskes

This comment has been minimized.

Show comment
Hide comment
@bleskes

bleskes Sep 23, 2015

Member

@jasontedor can you take a look?

Member

bleskes commented Sep 23, 2015

@jasontedor can you take a look?

@jasontedor jasontedor self-assigned this Sep 23, 2015

@jasontedor

This comment has been minimized.

Show comment
Hide comment
@jasontedor

jasontedor Sep 23, 2015

Member

LGTM.

Member

jasontedor commented Sep 23, 2015

LGTM.

@jasontedor jasontedor removed the review label Sep 23, 2015

@bleskes bleskes closed this in d62f864 Sep 23, 2015

@bleskes bleskes deleted the bleskes:simplify_udpate_task branch Sep 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment