Skip to content

Test investigation: [CI] ILMDownsampleDisruptionIT testILMDownsampleRollingRestart #137363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2025
Merged

Test investigation: [CI] ILMDownsampleDisruptionIT testILMDownsampleRollingRestart #137363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a92594c
Add extra logging
gmarouli Oct 30, 2025
135ffd8
Apply suggestions from code review
gmarouli Oct 30, 2025
c32d7f7
Nits
gmarouli Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,9 +456,6 @@ tests:
- class: org.elasticsearch.test.rest.yaml.RcsCcsCommonYamlTestSuiteIT
method: test {p0=search.vectors/200_dense_vector_docvalue_fields/Enable docvalue_fields parameter for dense_vector fields}
issue: https://github.com/elastic/elasticsearch/issues/136443
- class: org.elasticsearch.xpack.downsample.ILMDownsampleDisruptionIT
method: testILMDownsampleRollingRestart
issue: https://github.com/elastic/elasticsearch/issues/136585
- class: org.elasticsearch.xpack.esql.heap_attack.HeapAttackIT
method: testManyConcat
issue: https://github.com/elastic/elasticsearch/issues/136728
Expand Down
8 changes: 8 additions & 0 deletions test/framework/src/main/java/org/elasticsearch/test/TestCluster.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ public void wipeIndices(String... indices) {

private void wipeIndicesAsync(String[] indices, ActionListener<Void> listener) {
assert indices != null && indices.length > 0;
logger.info("---- wiping indices [{}]", Strings.arrayToCommaDelimitedString(indices));
SubscribableListener.<AcknowledgedResponse>newForked(
l -> client().admin()
.indices()
Expand All @@ -248,13 +249,15 @@ private void wipeIndicesAsync(String[] indices, ActionListener<Void> listener) {

private void handleWipeIndicesFailure(Exception exception, boolean wipingAllIndices, ActionListener<AcknowledgedResponse> listener) {
Throwable unwrapped = ExceptionsHelper.unwrap(exception, IndexNotFoundException.class, IllegalArgumentException.class);
logger.error("---- initial wiping of indices failed", exception);
if (unwrapped instanceof IndexNotFoundException) {
// ignore
listener.onResponse(AcknowledgedResponse.TRUE);
} else if (unwrapped instanceof IllegalArgumentException) {
// Happens if `action.destructive_requires_name` is set to true
// which is the case in the CloseIndexDisableCloseAllTests
if (wipingAllIndices) {
logger.info("---- retry wiping indices using their concrete names", exception);
SubscribableListener

.<ClusterStateResponse>newForked(l -> client().admin().cluster().prepareState(TEST_REQUEST_TIMEOUT).execute(l))
Expand All @@ -274,6 +277,11 @@ private void handleWipeIndicesFailure(Exception exception, boolean wipingAllIndi
// TODO: this is clearly wrong but at least
// org.elasticsearch.xpack.watcher.test.integration.BootStrapTests.testTriggeredWatchLoading depends on this
// quietly passing when it tries to delete an alias instead of its backing indices
logger.warn(
"This failure is ok, if this test is BootStrapTests.testTriggeredWatchLoading."
+ " Otherwise, please investigate this failure:",
exception
);
listener.onResponse(AcknowledgedResponse.TRUE);

}
Expand Down
5 changes: 5 additions & 0 deletions ...nternalClusterTest/java/org/elasticsearch/xpack/downsample/ILMDownsampleDisruptionIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import org.elasticsearch.search.aggregations.bucket.histogram.DateHistogramInterval;
import org.elasticsearch.test.ESIntegTestCase;
import org.elasticsearch.test.InternalTestCluster;
import org.elasticsearch.test.junit.annotations.TestIssueLogging;
import org.elasticsearch.xcontent.XContentBuilder;
import org.elasticsearch.xcontent.XContentFactory;
import org.elasticsearch.xpack.aggregatemetric.AggregateMetricMapperPlugin;
Expand Down Expand Up @@ -129,6 +130,10 @@ public void setup(final String sourceIndex, int numOfShards, int numOfReplicas,
assertAcked(client().execute(ILMActions.PUT, putLifecycleRequest).actionGet());
}

@TestIssueLogging(
value = "org.elasticsearch.cluster.service.MasterService:TRACE",
issueUrl = "https://github.com/elastic/elasticsearch/issues/136585"
)
public void testILMDownsampleRollingRestart() throws Exception {
final InternalTestCluster cluster = internalCluster();
cluster.startMasterOnlyNodes(1);
Expand Down