Skip to content

Improve MockApmServer support for transaction and span filtering #137433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
+29 −6
Merged

Improve MockApmServer support for transaction and span filtering #137433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 29 additions & 6 deletions build-tools/src/main/java/org/elasticsearch/gradle/testclusters/MockApmServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,11 @@

package org.elasticsearch.gradle.testclusters;

import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.node.ObjectNode;
import com.fasterxml.jackson.databind.util.LRUMap;
import com.fasterxml.jackson.databind.util.LookupCache;
import com.sun.net.httpserver.HttpExchange;
import com.sun.net.httpserver.HttpHandler;
import com.sun.net.httpserver.HttpServer;
Expand All @@ -28,7 +31,9 @@
import java.io.InputStreamReader;
import java.io.OutputStream;
import java.net.InetSocketAddress;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.regex.Pattern;
import java.util.stream.Collectors;

Expand All @@ -48,6 +53,8 @@
public class MockApmServer {
private static final Logger logger = Logging.getLogger(MockApmServer.class);
private static final org.slf4j.Logger log = LoggerFactory.getLogger(MockApmServer.class);
private static final LookupCache<String, String> transactionCache = new LRUMap(16, 16);

private final Pattern metricFilter;
private final Pattern transactionFilter;
private final Pattern transactionExcludesFilter;
Expand Down Expand Up @@ -136,22 +143,28 @@ private void logFiltered(InputStream body) throws IOException {
ObjectMapper mapper = new ObjectMapper();
try (BufferedReader reader = new BufferedReader(new InputStreamReader(body))) {
String line;
String tier = null;
String node = null;
String nodeMetadata = null;

List<JsonNode> spans = new ArrayList<>();

while ((line = reader.readLine()) != null) {
var jsonNode = mapper.readTree(line);

if (jsonNode.has("metadata")) {
node = jsonNode.path("metadata").path("service").path("node").path("configured_name").asText(null);
tier = jsonNode.path("metadata").path("labels").path("node_tier").asText(null);
nodeMetadata = jsonNode.path("metadata").path("service").path("node").path("configured_name").asText(null);
var tier = jsonNode.path("metadata").path("labels").path("node_tier").asText(null);
nodeMetadata += tier != null ? "/" + tier : "";

} else if (transactionFilter != null && jsonNode.has("transaction")) {
var transaction = jsonNode.get("transaction");
var name = transaction.get("name").asText();
if (transactionFilter.matcher(name).matches()
&& (transactionExcludesFilter == null || transactionExcludesFilter.matcher(name).matches() == false)) {
logger.lifecycle("Transaction [{}/{}]: {}", node, tier, transaction);
transactionCache.put(transaction.get("id").asText(), name);
logger.lifecycle("Transaction {} [{}]: {}", name, nodeMetadata, transaction);
}
} else if (jsonNode.has("span")) {
spans.add(jsonNode.get("span")); // make sure to record all transactions first
} else if (metricFilter != null && jsonNode.has("metricset")) {
var metricset = jsonNode.get("metricset");
var samples = (ObjectNode) metricset.get("samples");
Expand All @@ -161,10 +174,20 @@ private void logFiltered(InputStream body) throws IOException {
}
}
if (samples.isEmpty() == false) {
logger.lifecycle("Metricset [{}/{}]", node, tier, metricset);
logger.lifecycle("Metricset [{}]: {}", nodeMetadata, metricset);
}
}
}

// emit only spans for previously matched transactions using the transaction cache
for (var span : spans) {
var name = span.get("name").asText();
var transactionId = span.get("transaction_id").asText();
var transactionName = transactionCache.get(transactionId);
if (transactionName != null) {
logger.lifecycle("Span {} of {} [{}]: {}", name, transactionName, nodeMetadata, span);
}
}
}
}
}
Expand Down