From 46d869f518865040f57dfe0ebf6ff9f708b039cf Mon Sep 17 00:00:00 2001 From: Keith Massey Date: Fri, 7 Nov 2025 15:01:35 -0600 Subject: [PATCH 1/2] Logging SLM failures due to master node change at INFO level --- .../xpack/slm/SnapshotLifecycleTask.java | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/x-pack/plugin/slm/src/main/java/org/elasticsearch/xpack/slm/SnapshotLifecycleTask.java b/x-pack/plugin/slm/src/main/java/org/elasticsearch/xpack/slm/SnapshotLifecycleTask.java index 6e0071333d7ec..36d04f92d5f1d 100644 --- a/x-pack/plugin/slm/src/main/java/org/elasticsearch/xpack/slm/SnapshotLifecycleTask.java +++ b/x-pack/plugin/slm/src/main/java/org/elasticsearch/xpack/slm/SnapshotLifecycleTask.java @@ -7,6 +7,7 @@ package org.elasticsearch.xpack.slm; +import org.apache.logging.log4j.Level; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; import org.elasticsearch.ElasticsearchException; @@ -19,6 +20,7 @@ import org.elasticsearch.client.internal.OriginSettingClient; import org.elasticsearch.cluster.ClusterState; import org.elasticsearch.cluster.ClusterStateUpdateTask; +import org.elasticsearch.cluster.NotMasterException; import org.elasticsearch.cluster.ProjectState; import org.elasticsearch.cluster.SnapshotsInProgress; import org.elasticsearch.cluster.metadata.ProjectId; @@ -589,11 +591,14 @@ public ClusterState execute(ClusterState currentState) throws Exception { @Override public void onFailure(Exception e) { - logger.error( - "failed to record snapshot policy execution status [{}] for snapshot [{}] in policy [{}]: {}", - exception.isPresent() ? "failure" : "success", - snapshotId.getName(), - policyName, + logger.log( + e instanceof NotMasterException ? Level.INFO : Level.ERROR, + String.format( + "failed to record snapshot policy execution status [%s] for snapshot [%s] in policy [%s]", + exception.isPresent() ? "failure" : "success", + snapshotId.getName(), + policyName + ), e ); } From a200386dc2047b76ad8910a85f06ca389b8d002e Mon Sep 17 00:00:00 2001 From: Keith Massey Date: Fri, 7 Nov 2025 15:39:40 -0600 Subject: [PATCH 2/2] avoiding a forbidden method --- .../java/org/elasticsearch/xpack/slm/SnapshotLifecycleTask.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugin/slm/src/main/java/org/elasticsearch/xpack/slm/SnapshotLifecycleTask.java b/x-pack/plugin/slm/src/main/java/org/elasticsearch/xpack/slm/SnapshotLifecycleTask.java index 36d04f92d5f1d..17385db46361d 100644 --- a/x-pack/plugin/slm/src/main/java/org/elasticsearch/xpack/slm/SnapshotLifecycleTask.java +++ b/x-pack/plugin/slm/src/main/java/org/elasticsearch/xpack/slm/SnapshotLifecycleTask.java @@ -593,7 +593,7 @@ public ClusterState execute(ClusterState currentState) throws Exception { public void onFailure(Exception e) { logger.log( e instanceof NotMasterException ? Level.INFO : Level.ERROR, - String.format( + format( "failed to record snapshot policy execution status [%s] for snapshot [%s] in policy [%s]", exception.isPresent() ? "failure" : "success", snapshotId.getName(),