New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ShardTermVectorService to be on indices level as TermVectorService #13786

Merged
merged 1 commit into from Sep 25, 2015

Conversation

Projects
None yet
2 participants
@s1monw
Contributor

s1monw commented Sep 25, 2015

There is no need to have term vectors service on the shard level where it's
created for every shard. This commit moves it to a higher level which makes
shard creation slightly simpler and reduces the number of long living objects.

@rjernst

This comment has been minimized.

Show comment
Hide comment
@rjernst

rjernst Sep 25, 2015

Member

LGTM

Member

rjernst commented Sep 25, 2015

LGTM

Move ShardTermVectorService to be on indices level as TermVectorService
There is no need to have term vectors service on the shard level where it's
created for every shard. This commit moves it to a higher level which makes
shard creation slightly simpler and reduces the number of long living objects.

s1monw added a commit that referenced this pull request Sep 25, 2015

Merge pull request #13786 from s1monw/move_term_vector_to_node_level
Move ShardTermVectorService to be on indices level as TermVectorService

@s1monw s1monw merged commit 1f5bd49 into elastic:master Sep 25, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@s1monw s1monw deleted the s1monw:move_term_vector_to_node_level branch Sep 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment