New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reflection hacks from ElasticsearchException #13796

Merged
merged 4 commits into from Sep 25, 2015

Conversation

Projects
None yet
5 participants
@s1monw
Contributor

s1monw commented Sep 25, 2015

Today we use reflection where it's not needed anymore since java8 can
pass ctors around. This commit replaces runtime checks with compile time
checks which is always preferrable.

Remove reflection hacks from ElasticsearchException
Today we use reflection where it's not needed anymore since java8 can
pass ctors around. This commit replaces runtime checks with compile time
checks which is always preferrable.

jasontedor added some commits Sep 25, 2015

Use explicit ids for ElasticsearchExceptions
This commit adds explicit ids for managing ElasticsearchException
serialization. By adding explicit ids and unit tests for them, the ids
are less brittle and breakage can be more clearly detected.

@jasontedor jasontedor removed the review label Sep 25, 2015

@jasontedor jasontedor self-assigned this Sep 25, 2015

jasontedor added a commit that referenced this pull request Sep 25, 2015

Merge pull request #13796 from s1monw/remove_reflection_hacks_from_es…
…_exception

Remove reflection hacks from ElasticsearchException

@jasontedor jasontedor merged commit 6557781 into elastic:master Sep 25, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@jasontedor jasontedor deleted the s1monw:remove_reflection_hacks_from_es_exception branch Sep 25, 2015

@lcawl lcawl added :Core/Core and removed :Exceptions labels Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment