Add deprecation checks for indices with percolator fields #138118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c#137548) This change modifies the deprecation API to check for any indices prior to 9.latest that have percolator fields in the mappings. Any that do are then returned as required to be reindexed or deleted. Read-only is excluded as this would not fix the underlying transport version issue. Note this change only concerns user created indices. System indices will need to be addressed separately as part of the migration API, but should be able to share code. ES-13234
jdconrad
added
>non-issue
:Core/Infra/Transport API
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
added
v9.2.2
v8.19.8
Team:Core/Infra
jdconrad
added
the
auto-backport
mark-vieira
approved these changes
Nov 17, 2025
|
|
||
| private static boolean transportVersionBeforeCurrentMinorRelease(IndexMetadata indexMetadata) { | ||
| // We divide each transport version by 1000 to get the base id. | ||
| return indexMetadata.getTransportVersion().id() / 1000 < TransportVersion.current().id() / 1000; |
Contributor
There was a problem hiding this comment.
@rjernst is there a better way to calculate this? Right now this is just convention, right?
Contributor
Author
There was a problem hiding this comment.
I'm happy to update this in another PR, but given limited time, I'm going to get rolling on the backports.
Thanks for the review!
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Nov 17, 2025
…8118) This change modifies the deprecation API to check for any indices prior to 9.latest that have percolator fields in the mappings. Any that do are then returned as required to be reindexed or deleted. Read-only is excluded as this would not fix the underlying transport version issue. Note this change only concerns user created indices. System indices will need to be addressed separately as part of the migration API, but should be able to share code. ES-13234
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Nov 17, 2025
…8118) This change modifies the deprecation API to check for any indices prior to 9.latest that have percolator fields in the mappings. Any that do are then returned as required to be reindexed or deleted. Read-only is excluded as this would not fix the underlying transport version issue. Note this change only concerns user created indices. System indices will need to be addressed separately as part of the migration API, but should be able to share code. ES-13234
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 17, 2025
…138192) Backport to [9.2] of #138118 This change modifies the deprecation API to check for any indices prior to 9.latest that have percolator fields in the mappings. Any that do are then returned as required to be reindexed or deleted. Read-only is excluded as this would not fix the underlying transport version issue. Note this change only concerns user created indices. System indices will need to be addressed separately as part of the migration API, but should be able to share code. ES-13234
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 17, 2025
…138197) Backport to [9.1] of #138118 This change modifies the deprecation API to check for any indices prior to 9.latest that have percolator fields in the mappings. Any that do are then returned as required to be reindexed or deleted. Read-only is excluded as this would not fix the underlying transport version issue. Note this change only concerns user created indices. System indices will need to be addressed separately as part of the migration API, but should be able to share code. ES-13234
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Nov 17, 2025
…8118) This change modifies the deprecation API to check for any indices prior to 9.latest that have percolator fields in the mappings. Any that do are then returned as required to be reindexed or deleted. Read-only is excluded as this would not fix the underlying transport version issue. Note this change only concerns user created indices. System indices will need to be addressed separately as part of the migration API, but should be able to share code. ES-13234
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 18, 2025
…8118) (#138200) Backport to [8.19] of #138118 This change modifies the deprecation API to check for any indices prior to 9.latest that have percolator fields in the mappings. Any that do are then returned as required to be reindexed or deleted. Read-only is excluded as this would not fix the underlying transport version issue. Note this change only concerns user created indices. System indices will need to be addressed separately as part of the migration API, but should be able to share code. ES-13234
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does two things: