Fix integer overflow in block memory estimation #138132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi @dnhatn, I've created a changelog YAML for you. |
dnhatn
added
v9.2.1
v9.1.8
v8.19.8
auto-backport
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
ivancea
approved these changes
Nov 17, 2025
Member
Author
|
@ChrisHegarty @ivancea Thanks for the review! |
This was referenced Nov 17, 2025
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Nov 17, 2025
When constructing a very large block, the memory estimate (multiplying two int values) can overflow, yielding a negative value instead of several GB. The negative estimate bypasses the circuit breaker, so the allocation proceeds and may lead to OOM. This change fixes the overflow by casting to long before multiplication so the breaker can trigger correctly. We should avoid allocating a gigantic contiguous primitive array; once size crosses a threshold we should switch to BigArray. I will address it in a follow-up.
Collaborator
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Nov 17, 2025
When constructing a very large block, the memory estimate (multiplying two int values) can overflow, yielding a negative value instead of several GB. The negative estimate bypasses the circuit breaker, so the allocation proceeds and may lead to OOM. This change fixes the overflow by casting to long before multiplication so the breaker can trigger correctly. We should avoid allocating a gigantic contiguous primitive array; once size crosses a threshold we should switch to BigArray. I will address it in a follow-up.
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Nov 17, 2025
When constructing a very large block, the memory estimate (multiplying two int values) can overflow, yielding a negative value instead of several GB. The negative estimate bypasses the circuit breaker, so the allocation proceeds and may lead to OOM. This change fixes the overflow by casting to long before multiplication so the breaker can trigger correctly. We should avoid allocating a gigantic contiguous primitive array; once size crosses a threshold we should switch to BigArray. I will address it in a follow-up.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 17, 2025
When constructing a very large block, the memory estimate (multiplying two int values) can overflow, yielding a negative value instead of several GB. The negative estimate bypasses the circuit breaker, so the allocation proceeds and may lead to OOM. This change fixes the overflow by casting to long before multiplication so the breaker can trigger correctly. We should avoid allocating a gigantic contiguous primitive array; once size crosses a threshold we should switch to BigArray. I will address it in a follow-up.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 17, 2025
When constructing a very large block, the memory estimate (multiplying two int values) can overflow, yielding a negative value instead of several GB. The negative estimate bypasses the circuit breaker, so the allocation proceeds and may lead to OOM. This change fixes the overflow by casting to long before multiplication so the breaker can trigger correctly. We should avoid allocating a gigantic contiguous primitive array; once size crosses a threshold we should switch to BigArray. I will address it in a follow-up.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 17, 2025
When constructing a very large block, the memory estimate (multiplying two int values) can overflow, yielding a negative value instead of several GB. The negative estimate bypasses the circuit breaker, so the allocation proceeds and may lead to OOM. This change fixes the overflow by casting to long before multiplication so the breaker can trigger correctly. We should avoid allocating a gigantic contiguous primitive array; once size crosses a threshold we should switch to BigArray. I will address it in a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When constructing a very large block, the memory estimate (multiplying two int values) can overflow, yielding a negative value instead of several GB. The negative estimate bypasses the circuit breaker, so the allocation proceeds and may lead to OOM.
This change fixes the overflow by casting to long before multiplication so the breaker can trigger correctly.
We should avoid allocating a gigantic contiguous primitive array; once size crosses a threshold we should switch to BigArray. I will address it in a follow-up.