From 33c1e6b4956e648299e205dba9ceb4d32c91492d Mon Sep 17 00:00:00 2001 From: Simon Cooper Date: Mon, 17 Nov 2025 14:29:58 +0000 Subject: [PATCH 1/2] Don't run DirectIOIT if feature flag is not enabled --- .../java/org/elasticsearch/index/store/DirectIOIT.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/server/src/internalClusterTest/java/org/elasticsearch/index/store/DirectIOIT.java b/server/src/internalClusterTest/java/org/elasticsearch/index/store/DirectIOIT.java index c8ceb200ea0b3..578182b7e5aec 100644 --- a/server/src/internalClusterTest/java/org/elasticsearch/index/store/DirectIOIT.java +++ b/server/src/internalClusterTest/java/org/elasticsearch/index/store/DirectIOIT.java @@ -20,6 +20,7 @@ import org.apache.lucene.tests.util.LuceneTestCase; import org.elasticsearch.common.settings.Settings; import org.elasticsearch.core.Strings; +import org.elasticsearch.index.codec.vectors.es93.ES93GenericFlatVectorsFormat; import org.elasticsearch.plugins.Plugin; import org.elasticsearch.search.vectors.KnnSearchBuilder; import org.elasticsearch.search.vectors.VectorData; @@ -58,6 +59,8 @@ public static void checkSupported() { } catch (IOException e) { SUPPORTED = false; } + + assumeTrue("Generic format supporting direct IO not enabled", ES93GenericFlatVectorsFormat.GENERIC_VECTOR_FORMAT.isEnabled()); } static DirectIODirectory open(Path path) throws IOException { From 4c6f6064964d906bdde41caad3d0b5e63330f376 Mon Sep 17 00:00:00 2001 From: Simon Cooper Date: Mon, 17 Nov 2025 14:30:54 +0000 Subject: [PATCH 2/2] Unmute tests --- muted-tests.yml | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/muted-tests.yml b/muted-tests.yml index ee9656c7b2e5e..53c034dfcc3fd 100644 --- a/muted-tests.yml +++ b/muted-tests.yml @@ -450,12 +450,6 @@ tests: - class: org.elasticsearch.xpack.inference.integration.AuthorizationTaskExecutorMultipleNodesIT method: testCancellingAuthorizationTaskRestartsIt issue: https://github.com/elastic/elasticsearch/issues/138099 -- class: org.elasticsearch.index.store.DirectIOIT - method: testDirectIONotUsed {p0=bbq_disk} - issue: https://github.com/elastic/elasticsearch/issues/138102 -- class: org.elasticsearch.index.store.DirectIOIT - method: testDirectIOUsed {p0=bbq_disk} - issue: https://github.com/elastic/elasticsearch/issues/138104 - class: org.elasticsearch.xpack.shutdown.NodeShutdownIT method: testStalledShardMigrationProperlyDetected issue: https://github.com/elastic/elasticsearch/issues/115697 @@ -477,12 +471,6 @@ tests: - class: org.elasticsearch.xpack.downsample.DataStreamLifecycleDownsampleIT method: testUpdateDownsampleSamplingMode issue: https://github.com/elastic/elasticsearch/issues/138135 -- class: org.elasticsearch.index.store.DirectIOIT - method: testDirectIONotUsed {p0=bbq_hnsw} - issue: https://github.com/elastic/elasticsearch/issues/138101 -- class: org.elasticsearch.index.store.DirectIOIT - method: testDirectIOUsed {p0=bbq_hnsw} - issue: https://github.com/elastic/elasticsearch/issues/138103 # Examples: #