Introduce large block doc values format #138182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkrik-es
changed the title
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
...c/main/java/org/elasticsearch/index/codec/tsdb/es819/ES819TSDBLargeBlockDocValuesFormat.java
Outdated
Show resolved
Hide resolved
...t/java/org/elasticsearch/index/codec/tsdb/es819/ES819TSDBLargeBlockDocValuesFormatTests.java
Outdated
Show resolved
Hide resolved
…into tsdb/codec-refactor-block-size
# Conflicts: # server/src/main/java/org/elasticsearch/index/codec/tsdb/es819/ES819TSDBDocValuesConsumer.java # server/src/main/java/org/elasticsearch/index/codec/tsdb/es819/ES819TSDBDocValuesFormat.java
…into tsdb/codec-refactor-block-size
# Conflicts: # server/src/main/java/org/elasticsearch/index/codec/tsdb/es819/ES819TSDBDocValuesFormat.java
martijnvg
reviewed
Nov 27, 2025
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
Thanks Kostas! This looks good. I left a few minor comments.
server/src/main/java/org/elasticsearch/index/codec/tsdb/es819/ES819TSDBDocValuesFormat.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| public static int randomNumericBlockSize() { | ||
| return random().nextBoolean() ? ES819TSDBDocValuesFormat.NUMERIC_LARGE_BLOCK_SHIFT : ES819TSDBDocValuesFormat.NUMERIC_BLOCK_SHIFT; |
Member
There was a problem hiding this comment.
Let's test with more blockshifts?
Contributor
Author
There was a problem hiding this comment.
Added an assert to check that only these two values are allowed. We can add more as needed.
server/src/main/java/org/elasticsearch/index/codec/tsdb/es819/ES819TSDBDocValuesProducer.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/codec/tsdb/es819/ES819TSDBDocValuesProducer.java
Show resolved
Hide resolved
martijnvg
reviewed
Nov 27, 2025
|
|
||
| // read in the entries from the metadata file. | ||
| int version = -1; | ||
| int blockShift = numericBlockShift; |
Member
There was a problem hiding this comment.
Should numericBlockShift always be ES819TSDBDocValuesFormat.NUMERIC_BLOCK_SHIFT?
Contributor
Author
There was a problem hiding this comment.
Good catch! No need to pass the arg, indeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new version of the existing tsdb doc values format that allows configuring the block size, adding 512 to the existing size of 128. The block size is included it codec metadata, so that blocks written with the larger setting will be read with this as well. This provides flexibility for configuring tsdb and logsdb indices differently, using the same codec version.
While this change bumps up the version, it should still be a no-op (other than writing and reading the block size to the metadata). The larger block size will be wired for use in tsdb indices in a follow-up change.
Related to #136307