Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions muted-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,30 +5,6 @@ tests:
- class: org.elasticsearch.packaging.test.PackagesSecurityAutoConfigurationTests
method: test20SecurityNotAutoConfiguredOnReInstallation
issue: https://github.com/elastic/elasticsearch/issues/112635
- class: org.elasticsearch.xpack.sql.qa.single_node.JdbcSqlSpecIT
method: test {case-functions.testSelectInsertWithLcaseAndLengthWithOrderBy}
issue: https://github.com/elastic/elasticsearch/issues/112642
- class: org.elasticsearch.xpack.sql.qa.single_node.JdbcSqlSpecIT
method: test {case-functions.testUcaseInline1}
issue: https://github.com/elastic/elasticsearch/issues/112641
- class: org.elasticsearch.xpack.sql.qa.single_node.JdbcSqlSpecIT
method: test {case-functions.testUpperCasingTheSecondLetterFromTheRightFromFirstName}
issue: https://github.com/elastic/elasticsearch/issues/112640
- class: org.elasticsearch.xpack.sql.qa.single_node.JdbcSqlSpecIT
method: test {case-functions.testUcaseInline3}
issue: https://github.com/elastic/elasticsearch/issues/112643
- class: org.elasticsearch.xpack.sql.qa.security.JdbcSqlSpecIT
method: test {case-functions.testUcaseInline1}
issue: https://github.com/elastic/elasticsearch/issues/112641
- class: org.elasticsearch.xpack.sql.qa.security.JdbcSqlSpecIT
method: test {case-functions.testUcaseInline3}
issue: https://github.com/elastic/elasticsearch/issues/112643
- class: org.elasticsearch.xpack.sql.qa.security.JdbcSqlSpecIT
method: test {case-functions.testUpperCasingTheSecondLetterFromTheRightFromFirstName}
issue: https://github.com/elastic/elasticsearch/issues/112640
- class: org.elasticsearch.xpack.sql.qa.security.JdbcSqlSpecIT
method: test {case-functions.testSelectInsertWithLcaseAndLengthWithOrderBy}
issue: https://github.com/elastic/elasticsearch/issues/112642
- class: org.elasticsearch.xpack.transform.integration.TransformIT
method: testStopWaitForCheckpoint
issue: https://github.com/elastic/elasticsearch/issues/106113
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,17 @@ protected int fetchSize() {
protected final void doTest() throws Throwable {
// we skip the tests in case of these locales because ES-SQL is Locale-insensitive for now
// while H2 does take the Locale into consideration
String[] h2IncompatibleLocales = new String[] { "tr", "az", "tr-TR", "tr-CY", "az-Latn", "az-Cyrl", "az-Latn-AZ", "az-Cyrl-AZ" };
String[] h2IncompatibleLocales = new String[] {
"tr",
"az",
"tr-TR",
"tr-CY",
"az-Latn",
"az-Cyrl",
"az-Latn-AZ",
"az-Cyrl-AZ",
"tr-Latn-TR",
"az-AZ" };
boolean goodLocale = Arrays.stream(h2IncompatibleLocales)
.anyMatch((l) -> Locale.getDefault().equals(new Locale.Builder().setLanguageTag(l).build())) == false;
if (fileName.startsWith("case-functions")) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
// To mute tests follow example in file: example.sql-spec

// For anyone reaching this file in the future coming from CI failures related to uppercasing/lowercasing tests:
// For example: Different result for column [upper], entry [1] expected:< ELAST[İ]C > but was:< ELAST[I]C >
// Go to SqlSpecTestCase.doTest() method and look for h2IncompatibleLocales and add the faulty Locale there,
// after you double check that the issue is indeed related to that specific Locale.

// Next 4 SELECTs in this file are related to https://github.com/elastic/elasticsearch/issues/32589
// H2 is Locale sensitive, while ES-SQL is not (so far)

selectInsertWithLcaseAndLengthWithOrderBy
SELECT "first_name" origFN, "last_name" origLN, INSERT(UCASE("first_name"),LENGTH("first_name")+1,123,LCASE("last_name")) modified FROM "test_emp" WHERE ASCII("first_name")=65 ORDER BY "first_name" ASC, "last_name" ASC LIMIT 10;

Expand Down