Skip to content

[GPU] Add license check to the x-pack plugin #138491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 25, 2025
Merged

[GPU] Add license check to the x-pack plugin #138491

merged 4 commits into from
Nov 25, 2025
+108 −14

Conversation

@ldematte
Copy link
Contributor

@ldematte ldematte commented Nov 24, 2025

EOM

@ldematte ldematte added >non-issue auto-backport Automatically create backport pull requests when merged :Search Relevance/Vectors Vector search test-gpu Run tests using a GPU branch:9.2 labels Nov 24, 2025
@elasticsearchmachine elasticsearchmachine added Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.2.2 v9.3.0 and removed branch:9.2 labels Nov 24, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Nov 24, 2025

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@ChrisHegarty
Copy link
Contributor

ChrisHegarty commented Nov 24, 2025

Mostly looks good. Do we need to do anything for the yaml tests? Like setting a trial license or something ?

@ldematte
Copy link
Contributor Author

ldematte commented Nov 24, 2025 •
edited
Loading

Mostly looks good. Do we need to do anything for the yaml tests? Like setting a trial license or something ?

I think you are right; I was waiting for CI to run tests for me but as usual test-gpu is failing. Let me run tests on my box and see if we need an adjustment there.

EDIT: we are already doing that, so yaml tests are OK (passing)

@ldematte
Copy link
Contributor Author

ldematte commented Nov 24, 2025

IT tests needed some adjustment though :)

mayya-sharipova
mayya-sharipova approved these changes Nov 24, 2025
View reviewed changes
Copy link
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ldematte Thanks, this LGTM

@ldematte ldematte removed the test-gpu Run tests using a GPU label Nov 25, 2025
@ldematte ldematte enabled auto-merge (squash) November 25, 2025 14:55
@ldematte ldematte merged commit 154023e into elastic:main Nov 25, 2025
34 checks passed
@ldematte ldematte mentioned this pull request Nov 25, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Nov 25, 2025

💚 Backport successful

Status Branch Result
✅ 9.2

ldematte added a commit to ldematte/elasticsearch that referenced this pull request Nov 25, 2025
@ldematte
[GPU] Add license check to the x-pack plugin (elastic#138491)
0091bd8
elasticsearchmachine pushed a commit that referenced this pull request Nov 25, 2025
@ldematte
[GPU] Add license check to the x-pack plugin (#138491) (#138604)
79d0684
ncordon pushed a commit to ncordon/elasticsearch that referenced this pull request Nov 26, 2025
@ldematte @ncordon
[GPU] Add license check to the x-pack plugin (elastic#138491)
5e4a055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mayya-sharipova mayya-sharipova mayya-sharipova approved these changes

@ChrisHegarty ChrisHegarty Awaiting requested review from ChrisHegarty

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged >non-issue :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.2.2 v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ldematte @elasticsearchmachine @ChrisHegarty @mayya-sharipova