-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Use Wrapped Action Listeners in ShardBulkInferenceActionFilter #138505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Wrapped Action Listeners in ShardBulkInferenceActionFilter #138505
Conversation
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
jimczi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's log the error too?
...ain/java/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilter.java
Outdated
Show resolved
Hide resolved
...ain/java/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilter.java
Outdated
Show resolved
Hide resolved
kderusso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree on error over warn otherwise LGTM
💔 Backport failed
You can use sqren/backport to manually backport by running |
…ic#138505) (cherry picked from commit e286663) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilter.java
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
…ic#138505) (cherry picked from commit e286663) # Conflicts: # x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilter.java
Use wrapped action listeners in
ShardBulkInferenceActionFilterto ensure that any exceptions thrown duringonResponsehandling are reported.