Skip to content

Conversation

@Mikep86
Copy link
Contributor

@Mikep86 Mikep86 commented Nov 24, 2025

Use wrapped action listeners in ShardBulkInferenceActionFilter to ensure that any exceptions thrown during onResponse handling are reported.

@Mikep86 Mikep86 requested review from Tim-Brooks and jimczi November 24, 2025 14:05
@Mikep86 Mikep86 added >non-issue :SearchOrg/Relevance Label for the Search (solution/org) Relevance team labels Nov 24, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Search - Relevance The Search organization Search Relevance team label Nov 24, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's log the error too?

Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree on error over warn otherwise LGTM

@Mikep86 Mikep86 added auto-backport Automatically create backport pull requests when merged branch:9.2 branch:9.1 branch:8.19 labels Nov 24, 2025
@Mikep86 Mikep86 merged commit e286663 into elastic:main Nov 24, 2025
33 of 34 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.2
8.19 Commit could not be cherrypicked due to conflicts
9.1 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 138505

Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Nov 24, 2025
Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Nov 24, 2025
…ic#138505)

(cherry picked from commit e286663)

# Conflicts:
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilter.java
@Mikep86
Copy link
Contributor Author

Mikep86 commented Nov 24, 2025

💚 All backports created successfully

Status Branch Result
9.1
8.19

Questions ?

Please refer to the Backport tool documentation

Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Nov 24, 2025
…ic#138505)

(cherry picked from commit e286663)

# Conflicts:
#	x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/action/filter/ShardBulkInferenceActionFilter.java
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Nov 26, 2025
ncordon pushed a commit to ncordon/elasticsearch that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending >non-issue :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search - Relevance The Search organization Search Relevance team v8.19.8 v9.1.8 v9.2.2 v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants