Skip to content

Conversation

@mouhc1ne
Copy link
Contributor

@mouhc1ne mouhc1ne commented Nov 24, 2025

Add ALL_FIRST/ALL_LAST unit tests, serialization tests, and documentation material (csv-test doc sample, md, json, etc.). The unit tests use the same logic as the existing FIST/LAST, which was refactored and moved to the abstract test class.

Here is what the two functions would look like if they were added to the docs.


Screenshot 2025-11-25 at 2 48 12 PM
Screenshot 2025-11-25 at 2 48 24 PM

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.3.0 labels Nov 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

@github-actions
Copy link
Contributor

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

@mouhc1ne mouhc1ne self-assigned this Nov 24, 2025
@mouhc1ne mouhc1ne added >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL labels Nov 24, 2025
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Nov 24, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@mouhc1ne mouhc1ne added the >docs General docs changes label Nov 24, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Nov 24, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/core-docs (Team:Docs)

@mouhc1ne mouhc1ne force-pushed the all-first-all-last-unit-tests branch 4 times, most recently from 82c9f2b to f598059 Compare November 25, 2025 20:23
- Add ALL_FIRST/ALL_LAST unit tests, serialization tests, and documentation material (csv-test doc sample, md, json, etc.).
@mouhc1ne mouhc1ne force-pushed the all-first-all-last-unit-tests branch from f598059 to 5303123 Compare November 25, 2025 20:26
Copy link
Contributor

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

import static org.elasticsearch.xpack.esql.expression.function.MultiRowTestCaseSupplier.unlimitedSuppliers;
import static org.hamcrest.Matchers.anyOf;

public abstract class AbstractFirstLastTestCase extends AbstractAggregationTestCase {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I thought this was temporary, but see now it is shared between all four functions, so the removal of two functions still gives this class value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. This one is definitely gonna survive the imminent blast heading straight to the existing first and last 🤣

@mouhc1ne mouhc1ne merged commit 28d5b39 into elastic:main Nov 27, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL >docs General docs changes >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants