-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[ES|QL] Support for First/Last - Unit Testing #138536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Pinging @elastic/core-docs (Team:Docs) |
82c9f2b to
f598059
Compare
- Add ALL_FIRST/ALL_LAST unit tests, serialization tests, and documentation material (csv-test doc sample, md, json, etc.).
f598059 to
5303123
Compare
craigtaverner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| import static org.elasticsearch.xpack.esql.expression.function.MultiRowTestCaseSupplier.unlimitedSuppliers; | ||
| import static org.hamcrest.Matchers.anyOf; | ||
|
|
||
| public abstract class AbstractFirstLastTestCase extends AbstractAggregationTestCase { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first I thought this was temporary, but see now it is shared between all four functions, so the removal of two functions still gives this class value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. This one is definitely gonna survive the imminent blast heading straight to the existing first and last 🤣
Add
ALL_FIRST/ALL_LASTunit tests, serialization tests, and documentation material (csv-test doc sample, md, json, etc.). The unit tests use the same logic as the existingFIST/LAST, which was refactored and moved to the abstract test class.Here is what the two functions would look like if they were added to the docs.