Add a feature flag for reindex resilience #138618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not used yet, but several related streams of work will be hidden behind it until they are ready for production.
PeteGillinElastic
added
>non-issue
:Distributed Indexing/Reindex
elasticsearchmachine
added
Team:Distributed Indexing
Collaborator
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
samxbr
approved these changes
Nov 25, 2025
| /** | ||
| * A {@link FeatureFlag} to guard the work to make reindex more resilient while it is under development. | ||
| */ | ||
| static final FeatureFlag REINDEX_RESILIENCE_FEATURE_FLAG = new FeatureFlag("reindex_resilience"); |
Contributor
There was a problem hiding this comment.
nit: I have seem usage like this which looks neat.
Member
Author
There was a problem hiding this comment.
That's a good idea. We're never going to do anything other than call isEnabled() on it, so it makes the call sites nicer to just be able to reference the boolean. So I've done that, please LMK how it looks to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not used yet, but several related streams of work will be hidden behind it until they are ready for production.
Closes elastic/elasticsearch-team#2084