Improved bulk loading for binary doc values #138631
Merged
+129
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Hi @parkertimmins, I've created a changelog YAML for you. |
martijnvg
approved these changes
Nov 26, 2025
| int blockDocOffset = 0; | ||
| int blockByteOffset = 0; | ||
| long[] offsets = new long[count + 1]; | ||
| List<BytesRef> decompressedBlocks = new ArrayList<>(); |
Member
There was a problem hiding this comment.
Maybe add a TODO, to account memory usage of decompressedBlocks? This could grow and have a significant jvm heap memory usage.
Eventually this will be accounted, but that happens when we hand over byte[] to the builder.
Member
|
I suspect most of the bwc failures are because of: |
…ing-compressed-binary-dv-dense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By decompressing all matching blocks into one byte array and appending that directly into the block builder.