-
Notifications
You must be signed in to change notification settings - Fork 25.6k
ESQL: Fix INLINE STATS + FORK + pushdown bug #138633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
| List<NamedExpression> projections = new ArrayList<>(project.projections()); | ||
| projections.addAll(addedAttrs.values()); | ||
| return project.withProjections(projections); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing this on Project helps here.
limotova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
carlosdelest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Fixes a bug that comes up when combining field loading pushown, INLINE STATS, and FORK. Speeds up pushdown rule by going in one pass.