[ML] Add "close_job" parameter to the stop datafeed API #138634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the stop datafeed API is called with close_job=true the job associated with the datafeed will be closed first, which in turn will result in the datafeed being closed. Closes elastic#138010
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Collaborator
|
Hi @edsavage, I've created a changelog YAML for you. |
…op_datafeed_close_job_param
…nto stop_datafeed_close_job_param
…op_datafeed_close_job_param
davidkyle
approved these changes
Nov 28, 2025
Member
davidkyle
left a comment
davidkyle
left a comment
There was a problem hiding this comment.
LGTM
Couple of minor comments. The change is well tested
| }); | ||
| } | ||
|
|
||
| private void doTestRealtime_GivenCloseJobParameter(String jobId, boolean closeJobParameter, JobState jobState) throws Exception { |
Member
There was a problem hiding this comment.
Are closeJobParameter and jobState used in this method?
| } | ||
| } | ||
| if (request.closeJob() && startedDatafeedsJobs.isEmpty() == false) { | ||
| // If the "close_job" parameter was set to "true" on the stop datafeed request we attempt to first close the |
Member
There was a problem hiding this comment.
In the close jobs action where the datafeed is stopped please explicitly set close job to false so when looking at that code we are aware of this interation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the stop datafeed API is called with close_job=true the job associated with the datafeed will be closed first, which in turn will result in the datafeed being closed.
Closes #138010