Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to spatial4j 0.5 for correct Multi-Geometry #14269

Merged
merged 1 commit into from Oct 28, 2015

Conversation

Projects
None yet
3 participants
@nknize
Copy link
Member

commented Oct 23, 2015

A long time coming this upgrades to Spatial4J 0.5 which includes the fix for calculating a Multi-geometry bounding box. Duplicate code is removed

closes #9904

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Oct 23, 2015

this PR is missing updates for license files can you add it?

@nknize

This comment has been minimized.

Copy link
Member Author

commented Oct 26, 2015

signature and license files updated.

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2015

LGTM - @clintongormley does the notice file etc look good to? why didn't we have one before?

@nknize

This comment has been minimized.

Copy link
Member Author

commented Oct 26, 2015

@s1monw Spatial4j moved to locationtech.org which is under the Eclipse Foundation. The notice file is the eclipse SUA and needs to be provided along with the "unless otherwise indicated" license file (in this case ASL2.0).

@clintongormley

This comment has been minimized.

Copy link
Member

commented Oct 26, 2015

NOTICE file looks good.

@nknize nknize force-pushed the nknize:fix/9904 branch Oct 28, 2015

Fix Multi-geometry bbox
A long time coming this Upgrades to Spatial4J 0.5 which includes the fix for calculating a Multi-geometry bounding box.

@nknize nknize force-pushed the nknize:fix/9904 branch to 3d970f1 Oct 28, 2015

@nknize nknize merged commit 3d970f1 into elastic:master Oct 28, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@nknize nknize deleted the nknize:fix/9904 branch May 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.