Deduplicate cause if already contained in shard failures #14432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1monw
force-pushed
the
add_shard_failure_as_suppressed
branch
from
9504a17
to
905bbea
Compare
s1monw
changed the title
|
LGTM |
| throw new IllegalArgumentException("shardSearchFailures must not be null"); | ||
| } | ||
| // if the cause of this exception is also the cause of one of the shard failures we don't add it | ||
| // to prevent duplication in stack traces rendered to the REST layer |
There was a problem hiding this comment.
if the issue is the rest layer, should we instead:
- keep the cause as-is
- at serialization time, add a magic number when serializing shard failures if they are the same as the cause of the top-level exception and deserialize by copying the cause
- at rendering time (toxcontent) not render stack traces of shard failures if they are the same as the top-level exception?
There was a problem hiding this comment.
not sure if it's relevant.... what I wanted there is to add a cause always to this exception which wasn't the case. if we do that we don't need to add it if we have it as a shard failure already since we override getCause so it's equivalent.
If we have a shard failure on SearchPhaseExecutionException we can deduplicate the original cause and use the more informative ShardSearchFailure containing the shard ID etc. but we should deduplicate the actual cause to prevent stack trace duplication.
s1monw
force-pushed
the
add_shard_failure_as_suppressed
branch
from
ca17498
to
3f94a56
Compare
|
OK, I had missed that this exception overrides getCause(). LGTM |
s1monw
added a commit
that referenced
this pull request
Nov 3, 2015
Deduplicate cause if already contained in shard failures
lcawl
added
:Core/Infra/Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have a shard failure on SearchPhaseExecutionException
we can deduplicate the original cause and use the more informative
ShardSearchFailure containing the shard ID etc. but we should deduplicate
the actual cause to prevent stack trace duplication.