Remove guice from the index level #14518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1monw
added
>breaking
review
:Core/Infra/Plugins
s1monw
force-pushed
the
simplify_index_level_services
branch
from
56b9b62
to
e2c6938
Compare
|
I'll review it in a bit. |
| @@ -922,7 +918,7 @@ private void markLastWrite() { | |||
| // We are currently inactive, but a new write operation just showed up, so we now notify IMC | |||
There was a problem hiding this comment.
Move this comment to indexingMemoryController?
|
This is great! A couple small comments, but LGTM. |
This commit removes guice from the index level and adds a simple extension point to add class instances with an index-lifecycle scope.
s1monw
force-pushed
the
simplify_index_level_services
branch
from
74e4d1b
to
cf0179b
Compare
s1monw
added a commit
that referenced
this pull request
Nov 5, 2015
Remove guice from the index level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a WIP first cut at removing guice from the index level. With this we will only have a single injector that we create on node startup. No wiring at index creation or so anymore, anything is setup up-front. At this point all tests pass and it's technically ready to merge but I need to integrate a bunch of plugins to ensure all stuff works.