Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Port of publishAddress should match port of corresponding boundAddress #14535
referenced this pull request
Nov 5, 2015
The http case must be also handled, but it should be significantly simpler. when looking at the list of bound addresses, find the first one where
you can see this easily by doing e.g.
The only other idea i had to make this better, would be to remove NetworkService.resolvePublishHostAddresses() completely: https://github.com/elastic/elasticsearch/blob/master/core/src/main/java/org/elasticsearch/common/network/NetworkService.java#L149-L150
The idea being, the caller must deal with this themselves. We could still have the "sorting logic" as a shared method somewhere so that both http and transport can use it, but then it would not be
Pushed a set of changes to address the comments.
@rmuir I like the idea of inlining and adapting