New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds exception objects to log messages. #14827

Merged
merged 1 commit into from Nov 25, 2015

Conversation

Projects
None yet
3 participants
@MaineC
Contributor

MaineC commented Nov 18, 2015

Also forwards exception objects through failure listeners eliminates another 17
calls to getMessage().

Relates to #10021

@rjernst

View changes

Show outdated Hide outdated core/src/main/java/org/elasticsearch/common/Base64.java
@rjernst

View changes

Show outdated Hide outdated core/src/test/java/org/elasticsearch/discovery/ZenFaultDetectionTests.java
@rjernst

This comment has been minimized.

Show comment
Hide comment
@rjernst

rjernst Nov 18, 2015

Member

This is great. These errors should be a little easier to debug now! LGTM

Member

rjernst commented Nov 18, 2015

This is great. These errors should be a little easier to debug now! LGTM

Isabel Drost-Fromm
Adds exception objects to log messages.
Also forwards exception objects through failure listeners eliminates another 17
calls to getMessage().

Relates to #10021

MaineC pushed a commit that referenced this pull request Nov 25, 2015

Isabel Drost-Fromm
Merge pull request #14827 from MaineC/bug-fix/10021-error-listeners
Adds exception objects to log messages.

@MaineC MaineC merged commit 473b194 into elastic:master Nov 25, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@lcawl lcawl added :Core/Core and removed :Exceptions labels Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment