Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve integ test startup behavior #14869

Merged
merged 1 commit into from Nov 19, 2015

Conversation

Projects
None yet
2 participants
@rjernst
Copy link
Member

commented Nov 19, 2015

As part of the refactoring to allow --debug-jvm with gradle run, the way
java options are passed for integ tests was changed. However, we need to
make sure the jvm argline passed goes to ES_GC_OPTS because this
allows overriding things like which garbage collector we run, which we
do for testing from jenkins. This change adds back ES_GC_OPTS.

Build: Improve integ test startup behavior
As part of the refactoring to allow --debug-jvm with gradle run, the way
java options are passed for integ tests was changed. However, we need to
make sure the jvm argline passed goes to ES_GC_OPTS because this
allows overriding things like which garbage collector we run, which we
do for testing from jenkins. This change adds back ES_GC_OPTS.
@dakrone

This comment has been minimized.

Copy link
Member

commented Nov 19, 2015

LGTM

rjernst added a commit that referenced this pull request Nov 19, 2015

Merge pull request #14869 from rjernst/integ_test_java_opts
Improve integ test startup behavior

@rjernst rjernst merged commit cc6814f into elastic:master Nov 19, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@rjernst rjernst deleted the rjernst:integ_test_java_opts branch Nov 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.