Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wildcards for getting repositories and snapshots #15151

Merged
merged 1 commit into from Dec 11, 2015

Conversation

Projects
None yet
3 participants
@ywelsch
Copy link
Contributor

commented Dec 1, 2015

Supports the following:

GET /_snapshot/*
GET /_snapshot/repo*
GET /_snapshot/repo/*
GET /_snapshot/repo/prefix*

What is not supported:

GET /_snapshot/*/snap
GET /_snapshot/repo*/snap*

Relates to #4758

@dadoonet

This comment has been minimized.

Copy link
Member

commented Dec 1, 2015

Wondering if it requires some documentation changes?

@ywelsch

This comment has been minimized.

Copy link
Contributor Author

commented Dec 1, 2015

you're right, I'll add some docs.

@ywelsch

This comment has been minimized.

Copy link
Contributor Author

commented Dec 1, 2015

@dadoonet I've added documentation. Could you review this PR?

@dadoonet dadoonet added the review label Dec 1, 2015

@@ -94,7 +94,8 @@ public void testRepositoryCreation() throws Exception {
assertThat(repositoriesMetaData.repository("test-repo-2").type(), equalTo("fs"));

logger.info("--> check that both repositories can be retrieved by getRepositories query");
GetRepositoriesResponse repositoriesResponse = client.admin().cluster().prepareGetRepositories().get();

This comment has been minimized.

Copy link
@dadoonet

dadoonet Dec 1, 2015

Member

Can we still test prepareGetRepositories() without any parameter? Unless we test it somewhere else?

This comment has been minimized.

Copy link
@ywelsch

ywelsch Dec 10, 2015

Author Contributor

no parameter is tested in other places

@dadoonet

This comment has been minimized.

Copy link
Member

commented Dec 1, 2015

Left a very small comment about test. It looks good to me. I'd prefer that @bleskes double checks though.

@imotov

This comment has been minimized.

Copy link
Member

commented Dec 10, 2015

LGTM

@ywelsch ywelsch force-pushed the ywelsch:feature/get-snapshot-wildcards branch to db5594a Dec 11, 2015

ywelsch added a commit that referenced this pull request Dec 11, 2015

Merge pull request #15151 from ywelsch/feature/get-snapshot-wildcards
Support wildcards for getting repositories and snapshots

@ywelsch ywelsch merged commit ce50fb4 into elastic:master Dec 11, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

ywelsch added a commit that referenced this pull request Dec 11, 2015

brwe added a commit to brwe/elasticsearch that referenced this pull request Dec 15, 2015

fix SnapshotBackwardsCompatibilityIT to not use wildcards with 2.0
This was only introduced in 2.2 with elastic#15151 so we must not use
wildcards when running with 2.0 nodes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.