Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure Service Management API to 0.9.0 #15232

Merged
merged 1 commit into from Dec 4, 2015

Conversation

dadoonet
Copy link
Member

@dadoonet dadoonet commented Dec 4, 2015

Azure team released new versions of their Java SDK.

According to https://github.com/Azure/azure-sdk-for-java/wiki/Azure-SDK-for-Java-Features, it comes with 2 versions.
We should at least update to 0.9.0 of V1 but also consider moving to the new APIs (V2).

This commit first updates to latest API V1.

<dependency>
    <groupId>com.microsoft.azure</groupId>
    <artifactId>azure-svc-mgmt-compute</artifactId>
    <version>0.9.0</version>
</dependency>

Closes #15209

@dadoonet
Copy link
Member Author

dadoonet commented Dec 4, 2015

@tlrx Really small change. Can you review?

@tlrx
Copy link
Member

tlrx commented Dec 4, 2015

@dadoonet do you have a link to the changelog and an explanation why the library moves to API V2? I'm curious to know the benefit/tradeoffs of the new version.

@dadoonet
Copy link
Member Author

dadoonet commented Dec 4, 2015

Note that my change does not move to the V2.

And for now, I can't find any documentation on how to adapt from V1 to V2. Some APIs are not there anymore :(

@tlrx
Copy link
Member

tlrx commented Dec 4, 2015

Note that my change does not move to the V2.

Sure, I'm just asking for a changelog of 0.90.0 V1

@dadoonet
Copy link
Member Author

dadoonet commented Dec 4, 2015

@tlrx

2015.10.21 Version 0.9.0

  • New Azure Resource Manager Storage Management library
  • Fix a few bugs

2015.9.22 Version 0.8.3

  • Fix unexpected exceptions thrown in some long running operations

2015.9.22 Version 0.8.2

  • Revert a previous breaking change on enum casing
  • Fix string comparison on long running operation status

2015.9.15 Version 0.8.1

  • Use commons library for Base64 encoding

2015.8.21 Version 0.8.0

  • Support token based credentials
  • Support Azure Resource Management

The great news is that we might be able to change auth from certificate based auth to token based auth...
I would prefer doing that in another PR though.

@tlrx
Copy link
Member

tlrx commented Dec 4, 2015

"fix few bugs" I guess it motivates an update... LGTM

@dadoonet
Copy link
Member Author

dadoonet commented Dec 4, 2015

haha! Yeah. The changelog is super obvious...

I guess it basically says: read this: https://github.com/Azure/azure-sdk-for-java/commits/master

@dadoonet
Copy link
Member Author

dadoonet commented Dec 4, 2015

After trying to backport to 2.x branch, I found that some transitive dependencies are actually missing. I need to update gradle build file.
Will push another commit.

Azure team released new versions of their Java SDK.

According to https://github.com/Azure/azure-sdk-for-java/wiki/Azure-SDK-for-Java-Features, it comes with 2 versions.
We should at least update to `0.9.0` of V1 but also consider moving to the new APIs (V2).

This commit first updates to latest API V1.

```xml
<dependency>
    <groupId>com.microsoft.azure</groupId>
    <artifactId>azure-svc-mgmt-compute</artifactId>
    <version>0.9.0</version>
</dependency>
```

Closes elastic#15209
@dadoonet dadoonet merged commit 619fb99 into elastic:master Dec 4, 2015
@dadoonet dadoonet removed the review label Dec 4, 2015
@dadoonet dadoonet deleted the fix/15209-update-azure-sdk branch December 4, 2015 16:46
@clintongormley clintongormley added :Distributed/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs and removed :Plugin Discovery Azure Classic labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >upgrade v2.2.0 v5.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants