Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typo in class name of StatsAggregator #15264

Closed
wants to merge 5 commits into from
Closed

Correct typo in class name of StatsAggregator #15264

wants to merge 5 commits into from

Conversation

martinstuga
Copy link
Contributor

Closes #14730

@colings86
Copy link
Contributor

@martinstuga thanks for the PR, could you sign the Contributer Licence Agreeement (https://www.elastic.co/contributor-agreement/) so we can merge this?

@martinstuga
Copy link
Contributor Author

@colings86 I've already signed CLA twice. I don't know why, but it's still appearing as not signed. May you help me please?

@colings86
Copy link
Contributor

@martinstuga it looks like the email you used to sign the CLA is different from the email on your commit. You could add the email address you use in your commits to your Github profile (you can make it private so it doesn't show up on your public profile) and this will allow our CLA checker tool to link your Github commits with your CLA signature in the future.

@martinstuga martinstuga closed this Dec 7, 2015
@martinstuga martinstuga reopened this Dec 7, 2015
@martinstuga martinstuga changed the title Implementing #14730 Closes #14730 Dec 7, 2015
@martinstuga martinstuga closed this Dec 7, 2015
@martinstuga martinstuga reopened this Dec 7, 2015
@colings86 colings86 self-assigned this Dec 7, 2015
@colings86 colings86 changed the title Closes #14730 Correct typo in class name of StatsAggregator Dec 7, 2015
@martinstuga
Copy link
Contributor Author

Thanks for the help about the CLA. I'm seeing that you're going ahead with this issue.

@colings86
Copy link
Contributor

@martinstuga unfortunately at the moment the build fails with your change applied. Could you update this PR to fix the error, rebase your change onto the latest master and ensure gradle assemble runs successfully?

The error I get when running gradle assemble is:

$ES_REPO/core/src/main/java/org/elasticsearch/search/aggregations/metrics/stats/StatsParser.java:37: error: package StatsAggegator does not exist
        return new StatsAggegator.Factory(aggregationName, config);

@martinstuga martinstuga closed this Dec 7, 2015
martinstuga added a commit to martinstuga/elasticsearch that referenced this pull request Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants