New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AllTermQuery's scorer should skip segments that never saw the requested term #15506

Merged
merged 1 commit into from Dec 17, 2015

Conversation

Projects
None yet
4 participants
@mikemccand
Contributor

mikemccand commented Dec 17, 2015

Spinoff from this user's issue: https://discuss.elastic.co/t/2-1-0-nullpointerexception-not-sure-where-to-start/37419

When a segment never indexed the requested term, it has a null TermState, which means we should skip scoring that segment, and not cause an NPE.

@jpountz

This comment has been minimized.

Contributor

jpountz commented Dec 17, 2015

LGTM

1 similar comment
@nik9000

This comment has been minimized.

Contributor

nik9000 commented Dec 17, 2015

LGTM

@rmuir

This comment has been minimized.

Contributor

rmuir commented Dec 17, 2015

+1, thanks mike!

mikemccand pushed a commit that referenced this pull request Dec 17, 2015

Michael McCandless
Merge pull request #15506 from mikemccand/all_term_query_state
AllTermQuery's scorer should skip segments that never saw the requested term

@mikemccand mikemccand merged commit 086ea53 into elastic:master Dec 17, 2015

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@mikemccand mikemccand deleted the mikemccand:all_term_query_state branch Dec 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment