Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows service installation failure #15549

Merged
merged 1 commit into from Jan 21, 2016

Conversation

Projects
None yet
5 participants
@gmarz
Copy link
Member

commented Dec 18, 2015

When ES_HOME contains parentheses, parsing of the if statement around ES_CLASSPATH is thrown off. This fix enables delayed expansion in service.bat (already enabled in elasticsearch.bat).

Closes #15349

@russcam

This comment has been minimized.

Copy link
Contributor

commented Dec 23, 2015

Looks good to me @gmarz 👍

@spinscale spinscale added v2.2.1 and removed v2.2.0 labels Dec 23, 2015

@s1monw s1monw added v2.0.4 v2.1.3 and removed v2.3.0 v2.1.2 labels Jan 11, 2016

@clintongormley clintongormley added v2.0.3 and removed v2.0.3 v2.0.4 labels Jan 17, 2016

gmarz added a commit that referenced this pull request Jan 21, 2016

Merge pull request #15549 from gmarz/master
Fix Windows service installation failure

@gmarz gmarz merged commit 8fffc47 into elastic:master Jan 21, 2016

1 check passed

CLA Commit author has signed the CLA
Details

@gmarz gmarz added v2.2.0 v2.1.2 and removed v2.2.1 v2.1.3 labels Jan 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.