Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `missing` on terms aggs work with all execution modes. #15746

Merged
merged 1 commit into from Jan 6, 2016

Conversation

Projects
None yet
2 participants
@jpountz
Copy link
Contributor

commented Jan 4, 2016

There are two bugs:

  • the 'global_ordinals_low_cardinality' mode requires a fielddata-based impl so
    that it can extract the segment to global ordinal mapping
  • the 'global_ordinals_hash' mode abusively casts to the values source to a
    fielddata-based impl while it is not needed

Closes #14882

Make `missing` on terms aggs work with all execution modes.
There are two bugs:
 - the 'global_ordinals_low_cardinality' mode requires a fielddata-based impl so
   that it can extract the segment to global ordinal mapping
 - the 'global_ordinals_hash' mode abusively casts to the values source to a
   fielddata-based impl while it is not needed

Closes #14882
@colings86

This comment has been minimized.

Copy link
Member

commented Jan 5, 2016

LGTM

jpountz added a commit that referenced this pull request Jan 6, 2016

Merge pull request #15746 from jpountz/fix/missing_terms_agg
Make `missing` on terms aggs work with all execution modes.

@jpountz jpountz merged commit 7e3ccf2 into elastic:master Jan 6, 2016

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@jpountz jpountz deleted the jpountz:fix/missing_terms_agg branch Jan 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.