Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close recovered translog readers if createWriter fails #15762

Merged
merged 1 commit into from Jan 5, 2016

Conversation

Projects
None yet
4 participants
@s1monw
Copy link
Contributor

commented Jan 4, 2016

If we fail to create a writer all recovered translog readers are not
closed today which causes all open files to leak.

Closes #15754

@jasontedor @mikemccand can you take a look

Close recovered translog readers if createWriter fails
If we fail to create a writer all recovered translog readers are not
closed today which causes all open files to leak.

Closes #15754
@mikemccand

This comment has been minimized.

Copy link
Contributor

commented Jan 5, 2016

LGTM

@jasontedor

This comment has been minimized.

Copy link
Member

commented Jan 5, 2016

LGTM.

@s1monw s1monw added v5.0.0-alpha1 v2.2.1 and removed v2.2.0 labels Jan 5, 2016

@s1monw s1monw closed this Jan 5, 2016

@s1monw s1monw reopened this Jan 5, 2016

s1monw added a commit that referenced this pull request Jan 5, 2016

Merge pull request #15762 from s1monw/issues/15754
Close recovered translog readers if createWriter fails

@s1monw s1monw merged commit d4de8db into elastic:master Jan 5, 2016

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@s1monw s1monw deleted the s1monw:issues/15754 branch Jan 5, 2016

s1monw added a commit that referenced this pull request Jan 5, 2016

Merge pull request #15762 from s1monw/issues/15754
Close recovered translog readers if createWriter fails

s1monw added a commit that referenced this pull request Jan 5, 2016

Merge pull request #15762 from s1monw/issues/15754
Close recovered translog readers if createWriter fails

s1monw added a commit that referenced this pull request Jan 5, 2016

Merge pull request #15762 from s1monw/issues/15754
Close recovered translog readers if createWriter fails

s1monw added a commit that referenced this pull request Jan 5, 2016

Merge pull request #15762 from s1monw/issues/15754
Close recovered translog readers if createWriter fails

@s1monw s1monw added v2.3.0 v2.2.0 and removed v2.2.1 labels Jan 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.