Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent peer recovery from node with older version #15775

Merged
merged 1 commit into from Jan 6, 2016

Conversation

Projects
None yet
4 participants
@ywelsch
Copy link
Contributor

commented Jan 5, 2016

@brwe found an issue uncovered by the backward compatibility tests (http://build-us-00.elastic.co/job/es_core_2x_window-2012/328/) where we try to relocate a replica to an old node although the primary is on a new one.

I could track the issue down to a bug in the NodeVersionAllocationDecider which did not take this scenario into account (it compared node versions of old and new replica node, not node of primary shard which is used for peer recovery).

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Jan 5, 2016

this LGTM and I think this should go into 2.2, 2.1, 2.0 and 1.7 branches

@ywelsch ywelsch force-pushed the ywelsch:fix/node-versions-compatiblity branch Jan 5, 2016

@s1monw s1monw added v2.2.0 blocker and removed v2.2.1 labels Jan 5, 2016

Fix version-based allocation decider to prevent peer recovery from no…
…de with older version

Relocating a non-primary shard from one node to another is actually done by recovering from the active
primary shard in the cluster, and not the node that we are logically relocating from.

Closes #15775

@ywelsch ywelsch force-pushed the ywelsch:fix/node-versions-compatiblity branch to 55cc88e Jan 6, 2016

ywelsch added a commit that referenced this pull request Jan 6, 2016

Merge pull request #15775 from ywelsch/fix/node-versions-compatiblity
Prevent peer recovery from node with older version

@ywelsch ywelsch merged commit 501497d into elastic:master Jan 6, 2016

1 check passed

CLA Commit author is a member of Elasticsearch
Details

ywelsch added a commit that referenced this pull request Jan 6, 2016

Fix version-based allocation decider to prevent peer recovery from no…
…de with older version

Relocating a non-primary shard from one node to another is actually done by recovering from the active
primary shard in the cluster, and not the node that we are logically relocating from.

Closes #15775

ywelsch added a commit that referenced this pull request Jan 6, 2016

Fix version-based allocation decider to prevent peer recovery from no…
…de with older version

Relocating a non-primary shard from one node to another is actually done by recovering from the active
primary shard in the cluster, and not the node that we are logically relocating from.

Closes #15775

ywelsch added a commit that referenced this pull request Jan 6, 2016

Fix version-based allocation decider to prevent peer recovery from no…
…de with older version

Relocating a non-primary shard from one node to another is actually done by recovering from the active
primary shard in the cluster, and not the node that we are logically relocating from.

Closes #15775

ywelsch added a commit that referenced this pull request Jan 6, 2016

Fix version-based allocation decider to prevent peer recovery from no…
…de with older version

Relocating a non-primary shard from one node to another is actually done by recovering from the active
primary shard in the cluster, and not the node that we are logically relocating from.

Closes #15775

ywelsch added a commit that referenced this pull request Jan 6, 2016

Fix version-based allocation decider to prevent peer recovery from no…
…de with older version

Relocating a non-primary shard from one node to another is actually done by recovering from the active
primary shard in the cluster, and not the node that we are logically relocating from.

Closes #15775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.