Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe cluster state task notifications #15777

Merged
merged 1 commit into from Jan 5, 2016

Conversation

Projects
None yet
4 participants
@jasontedor
Copy link
Member

commented Jan 5, 2016

This commit addresses an issue where a cluster state task listener
throwing an exception could prevent other listeners from being notified,
and could prevent the executor from receiving notifications that a new
cluster state was published. Additionally, this commit also addresses a
similar issue for executors handling cluster state publication
notifications.

@nik9000

This comment has been minimized.

Copy link
Contributor

commented Jan 5, 2016

Oh nice! LGTM.

@bleskes

This comment has been minimized.

Copy link
Member

commented Jan 5, 2016

LGTM

Safe cluster state task notifications
This commit addresses an issue where a cluster state task listener
throwing an exception could prevent other listeners from being notified,
and could prevent the executor from receiving notifications that a new
cluster state was published. Additionally, this commit also addresses a
similar issue for executors handling cluster state publication
notifications.

@jasontedor jasontedor removed the review label Jan 5, 2016

jasontedor added a commit that referenced this pull request Jan 5, 2016

Merge pull request #15777 from jasontedor/safer-cluster-state-task-no…
…tifications

Safe cluster state task notifications

@jasontedor jasontedor merged commit d032dab into elastic:master Jan 5, 2016

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@jasontedor jasontedor deleted the jasontedor:safer-cluster-state-task-notifications branch Jan 5, 2016

@jasontedor

This comment has been minimized.

Copy link
Member Author

commented Jan 5, 2016

Thanks for reviewing @nik9000 and @bleskes.

jasontedor added a commit that referenced this pull request Jan 5, 2016

Safe cluster state task notifications
This commit backports commit d032dab
from master to 2.x.

Relates #15777

jasontedor added a commit that referenced this pull request Jan 5, 2016

Safe cluster state task notifications
This commit backports commit d032dab
from master to 2.2.

Relates #15777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.