Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PathHierarchy type back to path_hierarchy tokenizer for backward compatibility with 1.x #15785

Merged
merged 1 commit into from Jan 6, 2016

Conversation

Projects
None yet
4 participants
@ywelsch
Copy link
Contributor

commented Jan 6, 2016

Relates to #15756

@jpountz

This comment has been minimized.

Copy link
Contributor

commented Jan 6, 2016

Is there a way that we could only support it for indices created before 2.0 to ensure that new indices will use the lowercase version?

@jpountz

This comment has been minimized.

Copy link
Contributor

commented Jan 6, 2016

Maybe we could register a subclass of PathHierarchyTokenizerFactory whose constructor fails if the version in the index settings is >= 2.0? The error message could even point to the replacement to use?

@jpountz

This comment has been minimized.

Copy link
Contributor

commented Jan 6, 2016

Hmm after all we will have to do it for others analysis components (eg. edgeNGram) so let's push it as-is and work on a migration path as part of #8988

@ywelsch ywelsch force-pushed the ywelsch:fix/path-hierarchy-type branch Jan 6, 2016

@ywelsch ywelsch force-pushed the ywelsch:fix/path-hierarchy-type branch to de6dfe1 Jan 6, 2016

ywelsch added a commit that referenced this pull request Jan 6, 2016

Merge pull request #15785 from ywelsch/fix/path-hierarchy-type
Add PathHierarchy type back to path_hierarchy tokenizer for backward compatibility with 1.x

@ywelsch ywelsch merged commit e0599bf into elastic:master Jan 6, 2016

1 check passed

CLA Commit author is a member of Elasticsearch
Details

ywelsch added a commit that referenced this pull request Jan 6, 2016

ywelsch added a commit that referenced this pull request Jan 6, 2016

ywelsch added a commit that referenced this pull request Jan 6, 2016

ywelsch added a commit that referenced this pull request Jan 6, 2016

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Jan 6, 2016

@ywelsch this went into 2.2 as well can you label it accordingly?

@ywelsch ywelsch added v2.2.0 and removed v2.2.1 labels Jan 6, 2016

@ywelsch

This comment has been minimized.

Copy link
Contributor Author

commented Jan 6, 2016

@s1monw done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.