Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't override originalQuery with request filters #15793
These filters leak into highlighting and probably other places and cause things like the type name to be highlighted when using requireFieldMatch=false. We could have special hacks to keep them out of highlighting but it feals better to keep them out of any variable named "originalQuery".
I found this a bit scary at first as it adds a new method to be used to retrieve the query that we previously relied on (the filtered one) while the default one (parsedQuery) is not filtered anymore. That said I looked at where we call what and it seems ok, also if tests are green I suppose we are good :) LGTM then