Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BitSetFilterCache duplicates its content. #15836

Merged
merged 1 commit into from Jan 8, 2016

Conversation

Projects
None yet
4 participants
@jpountz
Copy link
Contributor

commented Jan 7, 2016

We have a bug that makes all per-index bitset caches store bitsets for all
indices. In the case that you have many indices, which is fairly common with
time-based data, this could translate to a lot of wasted memory.

Closes #15820

BitSetFilterCache duplicates its content.
We have a bug that makes all per-index bitset caches store bitsets for all
indices. In the case that you have many indices, which is fairly common with
time-based data, this could translate to a lot of wasted memory.

Closes #15820
@nik9000

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2016

LGTM

@jpountz

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2016

@martijnvg could you have a look since you're familiar with this cache?

@martijnvg

This comment has been minimized.

Copy link
Member

commented Jan 7, 2016

LGTM
Maybe we should back port this also to 1.7 branch? This is a bad bug.

jpountz added a commit that referenced this pull request Jan 8, 2016

Merge pull request #15836 from jpountz/fix/bitset_cache_duplicates
BitSetFilterCache duplicates its content.

@jpountz jpountz merged commit 581fd49 into elastic:master Jan 8, 2016

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@jpountz jpountz deleted the jpountz:fix/bitset_cache_duplicates branch Jan 8, 2016

@jpountz

This comment has been minimized.

Copy link
Contributor Author

commented Jan 8, 2016

Good point. I'll backport to 1.7 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.