Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial sizing of BytesStreamOutput. #15864

Merged

Conversation

Projects
None yet
3 participants
@jpountz
Copy link
Contributor

commented Jan 8, 2016

It currently tries to align to the page size (16KB) by default. However, this
might waste a significant memory (if many BytesStreamOutputs are allocated)
and is also useless given that BytesStreamOutput does not recycle (on the
contrary to ReleasableBytesStreamOutput). So the initial size has been changed
to 0.

Closes #15789

Fix initial sizing of BytesStreamOutput.
It currently tries to align to the page size (16KB) by default. However, this
might waste a significant memory (if many BytesStreamOutputs are allocated)
and is also useless given that BytesStreamOutput does not recycle (on the
contrary to ReleasableBytesStreamOutput). So the initial size has been changed
to 0.

Closes #15789
@jpountz

This comment has been minimized.

Copy link
Contributor Author

commented Jan 8, 2016

cc @s1monw

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2016

LGTM

jpountz added a commit that referenced this pull request Jan 11, 2016

Merge pull request #15864 from jpountz/fix/initial_sizing_of_BytesStr…
…eamOutput

Fix initial sizing of BytesStreamOutput.

@jpountz jpountz merged commit 77dbfbc into elastic:master Jan 11, 2016

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@jpountz jpountz deleted the jpountz:fix/initial_sizing_of_BytesStreamOutput branch Jan 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.