Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip capturing least/most FS info for an FS with no total #16001

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@dakrone
Copy link
Member

commented Jan 14, 2016

If an operating system reports -1 for the total bytes of a filesystem
path, we should ignore it when capturing the least and most available
statistics.

Relates to #15919

Skip capturing least/most FS info for an FS with no total
If an operating system reports -1 for the total bytes of a filesystem
path, we should ignore it when capturing the least and most available
statistics.

Relates to #15919
@rmuir

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2016

the logic looks fine for this, but we may want to add a test for negative free (but not total). I know this can happen on freebsd.

@dakrone

This comment has been minimized.

Copy link
Member Author

commented Jan 14, 2016

Pushed another commit that tests when 'free' is negative but total is not.

@rmuir

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2016

thanks!

@dakrone

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2016

I merged this into master and 2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.