Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't replace found fields if map unmapped fields as string is enabled #16043

Merged
merged 1 commit into from Jan 29, 2016

Conversation

Projects
None yet
2 participants
@martijnvg
Copy link
Member

commented Jan 17, 2016

PR for #10500

return fieldMapping;
} else if (mapUnmappedFieldAsString) {
StringFieldMapper.Builder builder = MapperBuilders.stringField(name);
return builder.build(new Mapper.BuilderContext(indexSettings.getSettings(), new ContentPath(1))).fieldType();
} else {
Version indexCreatedVersion = indexSettings.getIndexVersionCreated();

This comment has been minimized.

Copy link
@martijnvg

martijnvg Jan 17, 2016

Author Member

I will fix this on 2.x, 2.2 branches too, but when back porting I will not remove this bwc code here.

@jpountz

This comment has been minimized.

Copy link
Contributor

commented Jan 28, 2016

Good catch. LGTM

@clintongormley clintongormley changed the title [Percolator] Don't replace found fields if map unmapped fields as string is enabled Don't replace found fields if map unmapped fields as string is enabled Jan 28, 2016

@martijnvg martijnvg added the v2.3.0 label Jan 29, 2016

percolator: If `index.percolator.map_unmapped_fields_as_string` is en…
…abled then don't replace found fields with dummy string field

Closes #10500

@martijnvg martijnvg force-pushed the martijnvg:percolate/unmapped_fields branch to ce89039 Jan 29, 2016

@martijnvg martijnvg merged commit ce89039 into elastic:master Jan 29, 2016

1 check passed

CLA Commit author is a member of Elasticsearch
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.