Validate the settings key if it's simple chars separated by .
#16120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds additional safety to the settings since we don't have a full list of them yet and it caught bugs already in tests.
s1monw
added
>enhancement
review
:Core/Infra/Settings
| @@ -44,6 +45,9 @@ | |||
| private final Map<String, Setting<?>> complexMatchers = new HashMap<>(); | |||
| private final Map<String, Setting<?>> keySettings = new HashMap<>(); | |||
| private final Setting.Scope scope; | |||
| private static final Pattern KEY_PATTERN = Pattern.compile("^([\\w\\d_-]+[.])*[\\w\\d_-]+$"); | |||
There was a problem hiding this comment.
I think this should be:
^(?:[-\\w]+[.])*[-\\w]+$
- non-capturing groups (
(?:..)) are more efficient \walready includes\dand_- a
-inside[ ]should appear first, otherwise it indicates a range (at least in pcre)
|
@clintongormley I pushed updates :) |
|
LGTM |
s1monw
added a commit
that referenced
this pull request
Jan 20, 2016
Validate the settings key if it's simple chars separated by `.`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds additional safety to the settings since we don't have a full list of them
yet and it caught bugs already in tests.