Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ability to enable doc values with the `fielddata.format` setting. #16147

Closed

Conversation

Projects
None yet
4 participants
@jpountz
Copy link
Contributor

commented Jan 21, 2016

Doc values can now only be enabled by setting doc_values: true in the
mappings. Removing this feature also means that we can now fail mapping updates
that try to disable doc values.

Remove the ability to enable doc values with the `fielddata.format` s…
…etting.

Doc values can now only be enabled by setting `doc_values: true` in the
mappings. Removing this feature also means that we can now fail mapping updates
that try to disable doc values.
@rjernst

This comment has been minimized.

Copy link
Member

commented Jan 21, 2016

Great change, +1! I think we can do even better as a followup by removing the doc values as a boolean, since field type already has docvalues type?

@jpountz

This comment has been minimized.

Copy link
Contributor Author

commented Jan 21, 2016

Agreed this would simplify...

@jpountz

This comment has been minimized.

Copy link
Contributor Author

commented Jan 27, 2016

Fixed via 2aaa5e6

@jpountz jpountz closed this Jan 27, 2016

@ppf2

This comment has been minimized.

Copy link
Member

commented Mar 1, 2016

I just saw a mapping file out there in production that has fielddata.format set to doc_values. By removing this option entirely, will this be a breaking change? If so, can we add the tagging so we can also document this in the breaking changes doc for 5.0?

@jpountz

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2016

@ppf2 This is breaking in the sense that for new indices you will have to use doc_values: true instead. However it is backward compatible: existing 2.x indices that use fielddata.format=doc_values will keep working on 5.0.

@ppf2

This comment has been minimized.

Copy link
Member

commented Mar 1, 2016

@jpountz ok thx for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.