Allow the query cache to be disabled. #16268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Is having a custom query cache really something we should be promoting? It seems like allowing to disable it is one thing, and should be done with a boolean. |
|
I enabled it the way it was already implemented but I agree we probably want to keep things more contained. |
jpountz
force-pushed
the
feature/disable_query_cache
branch
from
c75fe10
to
83f2e08
Compare
|
Thanks @rjernst for the suggestion. I replaced the setting with a flag and removed the ability to configure custom query caches. |
|
This LGTM as is. I have 2 thoughts for the future:
|
I like the name better too so I will rename before merging. Thanks! |
This replaces the internal `index.queries.cache.type` setting with a new `index.queries.cache.enabled` setting, which is documented. Closes elastic#15802
jpountz
force-pushed
the
feature/disable_query_cache
branch
from
83f2e08
to
0eb1a81
Compare
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jun 14, 2016
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jun 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature already existed but was neither tested nor documented.
Closes #15802