Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exception class name to message in `NotSerializableExceptionWrapper` #16325

Merged
merged 1 commit into from Jan 31, 2016

Conversation

Projects
None yet
5 participants
@dakrone
Copy link
Member

dakrone commented Jan 29, 2016

Previously it's possible to get errors like:

Caused by: NotSerializableExceptionWrapper[d:\shared_data\afs-issue-1-1\23]

Which doesn't tell us what the underlying exception type was that could
not be serialized.

This changes the message to prepend the
ElasticsearchException.getExceptionName() of the exception (which is a
underscore case of the class with the leading 'Elasticsearch' removed)

@jasontedor

This comment has been minimized.

Copy link
Member

jasontedor commented Jan 29, 2016

LGTM.

Add Exception class name to message in `NotSerializableExceptionWrapper`
Previously it's possible to get errors like:

```
Caused by: NotSerializableExceptionWrapper[d:\shared_data\afs-issue-1-1\23]
```

Which doesn't tell us what the underlying exception type was that could
not be serialized.

This changes the message to prepend the
`ElasticsearchException.getExceptionName()` of the exception (which is a
underscore case of the class with the leading 'Elasticsearch' removed)

@dakrone dakrone force-pushed the dakrone:add-ex-name-to-msg branch to 7e05b34 Jan 30, 2016

@dakrone dakrone merged commit 7e05b34 into elastic:master Jan 31, 2016

1 check passed

CLA Commit author has signed the CLA
Details

@dakrone dakrone added the v2.2.1 label Feb 3, 2016

@dakrone dakrone deleted the dakrone:add-ex-name-to-msg branch Feb 4, 2016

@lcawl lcawl added :Core/Infra/Core and removed :Exceptions labels Feb 13, 2018

@guozhiyang

This comment has been minimized.

Copy link

guozhiyang commented Jun 7, 2018

Are you solve the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.