Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shard state action request logging #16396

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@jasontedor
Copy link
Member

commented Feb 3, 2016

This commit modifies the string representation of a shard state action
request. The issue being addressed is that the previous logging would
log failure: [Unknown] for shard started actions but this just leads
to confusion that there is a failure but its cause is unknown.

@jasontedor

This comment has been minimized.

Copy link
Member Author

commented Feb 3, 2016

See #16391 for an example where there might be some confusion that the shard started request is indicating a failure:

I'm also seeing this in the logs:

[2016-02-02 16:05:12,166][DEBUG][cluster.action.shard     ] [George Stacy] [analytics_test_201602][4] sending shard started for [analytics_test_201602][4], node[OcKoG1smQ0a__zSHxix33A], [P], v[1], s[INITIALIZING], a[id=ZgJoAG_vRGO6pVamLpHOHg], unassigned_info[[reason=INDEX_CREATED], at[2016-02-02T23:05:12.087Z]], expected_shard_size[7404], indexUUID [_WBlFe96TRO0kbG7S3ZgDg], message [after recovery from store], failure [Unknown]
Shard state action request logging
This commit modifies the string representation of a shard state action
request. The issue being addressed is that the previous logging would
log "failure: [Unknown]" for shard started actions but this just leads
to confusion that there is a failure but its cause is unknown.
@bleskes

This comment has been minimized.

Copy link
Member

commented Feb 3, 2016

LGTM

@jasontedor jasontedor closed this in 0b474c6 Feb 3, 2016

@jasontedor jasontedor deleted the jasontedor:shard-state-action-request-logging branch Feb 3, 2016

jasontedor added a commit that referenced this pull request Feb 3, 2016

Shard state action request logging
This commit backports commit 0b474c6
from master to 2.x.

Relates #16396

jasontedor added a commit that referenced this pull request Feb 3, 2016

Shard state action request logging
This commit backports commit 0b474c6
from master to 2.2.

Relates #16396

@jasontedor jasontedor added the v2.2.1 label Feb 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.