New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node version check to shard allocation during restore #16520

Merged
merged 1 commit into from Feb 23, 2016

Conversation

Projects
None yet
3 participants
@imotov
Member

imotov commented Feb 9, 2016

Verifies that the version of a node is compatible with the version of a shard that's being restored on this node.

Fixes #16519

@dakrone

This comment has been minimized.

Show comment
Hide comment
@dakrone

dakrone Feb 9, 2016

Member

LGTM

Member

dakrone commented Feb 9, 2016

LGTM

@bleskes

This comment has been minimized.

Show comment
Hide comment
@bleskes

bleskes Feb 9, 2016

Member

Thx @imotov . In the bug description you refer to "In a mixed cluster with a newer master node". Why is that newer master node relevant?

Member

bleskes commented Feb 9, 2016

Thx @imotov . In the bug description you refer to "In a mixed cluster with a newer master node". Why is that newer master node relevant?

@imotov

This comment has been minimized.

Show comment
Hide comment
@imotov

imotov Feb 9, 2016

Member

@bleskes Because a master that has a version older than the snapshot will refuse to restore the snapshot right away. So, we will not even get to shard allocation and therefore this problem will not occur. The problem occurs when we have a master that is version-compatible with the snapshot and some data nodes that are not.

Member

imotov commented Feb 9, 2016

@bleskes Because a master that has a version older than the snapshot will refuse to restore the snapshot right away. So, we will not even get to shard allocation and therefore this problem will not occur. The problem occurs when we have a master that is version-compatible with the snapshot and some data nodes that are not.

@imotov imotov added the v2.2.1 label Feb 22, 2016

Add node version check to shard allocation during restore
Verifies that the version of a node is compatible with the version of a shard that's being restored on this node.

Fixes #16519

@imotov imotov merged commit a9eb668 into elastic:master Feb 23, 2016

1 check passed

CLA Commit author is a member of Elasticsearch
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment