Has child query forces default similarity #16611
Conversation
|
@gpstathis Thanks! The change looks good. Can you squash the commits into a single commit? |
gpstathis
force-pushed
the
parent-child-similarities
branch
from
c2dc113
to
9c4a7ae
Compare
|
@martijnvg done! |
| @@ -1926,4 +1927,51 @@ public void testHasChildInnerQueryType() { | |||
| QueryBuilders.hasChildQuery("child-type", new IdsQueryBuilder().addIds("child-id"))).get(); | |||
| assertSearchHits(searchResponse, "parent-id"); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
@martijnvg can we do this with a unittest HasChildQueryBuilderTests should be able to verify this?
There was a problem hiding this comment.
agreed, that is better. We should just test the integration part here (whether non default similarity gets applied) and not whether right scores get computed.
There was a problem hiding this comment.
I'll add this test on top of this pr. For the 2.x branches we should still use the integ tests, since that is the only way to tests this stuff there.
|
@gpstathis I pushed this to master: b17a92c and I replaced the integration test with a unit test instead: 3290cfb When back porting to 2.x, your integration tests will guard that that the similarity is properly passed down the IndexSearcher. |
|
Thanks @martijnvg. |
clintongormley
changed the title
clintongormley
added
:Search/Search
@martijnvg, should already have a CLA signed from #4977. Closes #16550.