Updates to resiliency documentation #16658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -113,15 +90,27 @@ space. The following issues have been identified: | |||
| * Set a hard limit on `from`/`size` parameters {GIT}9311[#9311]. (STATUS: DONE, v2.1.0) | |||
| * Prevent combinatorial explosion in aggregations from causing OOM {GIT}8081[#8081]. (STATUS: ONGOING) | |||
| * Add the byte size of each hit to the request circuit breaker {GIT}9310[#9310]. (STATUS: ONGOING) | |||
| * Limit the size of requests {GIT}16011[#16011]. (STATUS: ONGOING) | |||
There was a problem hiding this comment.
maybe "limit the size of single requests and add a circuit breaker for the total memory used for inflight request objects"?
|
Thanks @ywelsch SO much for picking this up :) . I left some comments. |
|
@ywelsch we should probably add something about delayed allocation on node leave and synced flush (resilient to network hickups/long GC) |
|
@bleskes updated the docs with your suggestions (apart from your last comment on delayed allocation on node leave and synced flush) |
|
LGTM. Thanks Yannick, |
ywelsch
force-pushed
the
fix/resiliency-doc-updates
branch
from
193df5c
to
4ea8374
Compare
ywelsch
pushed a commit
that referenced
this pull request
Feb 19, 2016
Updates to resiliency documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the following updates: