Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix waiting for pidfile #16718

Merged
merged 1 commit into from Feb 29, 2016

Conversation

Projects
None yet
3 participants
@biolds
Copy link

commented Feb 18, 2016

Closes #16717

@clintongormley

This comment has been minimized.

Copy link
Member

commented Feb 28, 2016

@nik9000 could you take a look at this please

@nik9000

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2016

Will do on Monday.
On Feb 28, 2016 9:14 AM, "Clinton Gormley" notifications@github.com wrote:

@nik9000 https://github.com/nik9000 could you take a look at this please


Reply to this email directly or view it on GitHub
#16718 (comment)
.

@nik9000

This comment has been minimized.

Copy link
Contributor

commented Feb 29, 2016

Ok - reviewed. We should totally do this. Saying you wait for the pid and not waiting is not cool. The reason this hasn't come up before is that it usually shows up quickly anyway so this is hard to test. I'll see if I can put something together.

@nik9000

This comment has been minimized.

Copy link
Contributor

commented Feb 29, 2016

Ok - the vagrant based package tests aren't in working order at the moment (we don't run them in CI because we haven't done enough pre work) so I'll merge this sans test because its obviously better.

nik9000 added a commit that referenced this pull request Feb 29, 2016

@nik9000 nik9000 merged commit 97c4dd3 into elastic:master Feb 29, 2016

1 check passed

CLA Commit author has signed the CLA
Details

@nik9000 nik9000 removed the review label Feb 29, 2016

@nik9000

This comment has been minimized.

Copy link
Contributor

commented Feb 29, 2016

Thanks @biolds ! I'm going to backport this to the 2.x branch as well so it'll go out with 2.3.

@nik9000

This comment has been minimized.

Copy link
Contributor

commented Feb 29, 2016

Backported to 2.x with afbc98a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.