Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Hot inlined methods in your area #16725
An important optimization that a compiler can make is to inline
The methods that are hot but could not be inlined while benchmarking
This commit refactors most of the methods that are hot but the JVM could
The methods not addressed by this pull request are:
All other methods are addressed.
@bleskes I do, and there are issues which I've discussed with @danielmitterdorfer. The issue is that there is variance in the benchmark results which I found to be due to a large variance in the number of segments; this hides the impact of this change (which is expected to be small but positive).
I left a few minor comments here and there. I also ran the benchmarks multiple times but the changes hide in the run-to-run variance. Nevertheless, I think it is great to have shorter methods and it improves maintainability. Btw, I've also liked very much how you've split your commits for this PR.
Apart from the minor comments, LGTM.