Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call ensureOpen on Translog#newView() to prevent IllegalStateException #17191

Merged
merged 1 commit into from Mar 20, 2016

Conversation

Projects
None yet
3 participants
@s1monw
Copy link
Contributor

s1monw commented Mar 18, 2016

If a new view is pulled on a translog that was closed before the currently
committing translog was actually committed we run into odd IllegalStateExceptions
since we can't increment the ref count on the channel. This commit adds a missing
ensureOpen call to provide consistent AlreadyClosedExceptions.

Call ensureOpen on Translog#newView() to prevent IllegalStateException
If a new view is pulled on a translog that was closed before the currently
committing translog was actually committed we run into odd IllegalStateExceptions
since we can't increment the ref count on the channel. This commit adds a missing
ensureOpen call to provide consistent AlreadyClosedExceptions.

@s1monw s1monw force-pushed the s1monw:add_missing_ensure_open branch to 4507e1c Mar 18, 2016

@s1monw

This comment has been minimized.

Copy link
Contributor Author

s1monw commented Mar 18, 2016

@bleskes assigned it to you

@bleskes

This comment has been minimized.

Copy link
Member

bleskes commented Mar 18, 2016

LGTM. Was this signaled by a build failure?

@s1monw

This comment has been minimized.

Copy link
Contributor Author

s1monw commented Mar 20, 2016

LGTM. Was this signaled by a build failure?

I ran into looking at some logfiles... basically by accident :)

s1monw added a commit that referenced this pull request Mar 20, 2016

Merge pull request #17191 from s1monw/add_missing_ensure_open
Call ensureOpen on Translog#newView() to prevent IllegalStateException

If a new view is pulled on a translog that was closed before the currently
committing translog was actually committed we run into odd IllegalStateExceptions
since we can't increment the ref count on the channel. This commit adds a missing
ensureOpen call to provide consistent AlreadyClosedExceptions.

@s1monw s1monw merged commit accc221 into elastic:2.x Mar 20, 2016

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@s1monw s1monw deleted the s1monw:add_missing_ensure_open branch Mar 20, 2016

s1monw added a commit that referenced this pull request Mar 20, 2016

Merge pull request #17191 from s1monw/add_missing_ensure_open
Call ensureOpen on Translog#newView() to prevent IllegalStateException

If a new view is pulled on a translog that was closed before the currently
committing translog was actually committed we run into odd IllegalStateExceptions
since we can't increment the ref count on the channel. This commit adds a missing
ensureOpen call to provide consistent AlreadyClosedExceptions.

s1monw added a commit that referenced this pull request Mar 20, 2016

Merge pull request #17191 from s1monw/add_missing_ensure_open
Call ensureOpen on Translog#newView() to prevent IllegalStateException

If a new view is pulled on a translog that was closed before the currently
committing translog was actually committed we run into odd IllegalStateExceptions
since we can't increment the ref count on the channel. This commit adds a missing
ensureOpen call to provide consistent AlreadyClosedExceptions.

@s1monw s1monw added >bug v2.2.2 and removed >enhancement labels Mar 20, 2016

@clintongormley clintongormley added v2.3.0 and removed v2.3.1 labels Mar 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.